fix(factories): explicitly handle each value type #539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
levithomason
force-pushed
the
fix/factory-boolean-values
branch
from
a567c9b
to
112d38c
Compare
|
Ran locally and fixes the dropdown icon issue. Lgtm 👍 |
Current coverage is 98.86% (diff: 100%)@@ master #539 diff @@
==========================================
Files 108 108
Lines 1762 1762
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 1742 1742
Misses 20 20
Partials 0 0
|
|
Released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Factories were returning empty components give boolean values. This PR makes each return type explicitly list what it includes rather than excludes. The final else condition is null.