feat(ComponentExample): add github links to editor #586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
levithomason
force-pushed
the
feature/github-edit-and-issue
branch
from
c071bc7
to
f3eb2ab
Compare
levithomason
commented
Oct 3, 2016
| @@ -155,8 +159,8 @@ export default class ComponentExample extends Component { | |||
| // consider everything after the imports to be the body | |||
| // remove `export` statements except `export default class|function` | |||
| const body = _.get(/import[\s\S]*from '\w+'([\s\S]*)/.exec(sourceCode), '[1]', '') | |||
| .replace(/export\s+default\s+\w+([\s\n]+)?/, '') // remove `export default Foo` statements (lines) | |||
| .replace(/export\s+default\s+/, '') // remove `export default` | |||
| .replace(/export\s+default\s+(?!class|function)\w+([\s\n]+)?/, '') // remove `export default Foo` statements | |||
There was a problem hiding this comment.
Fixes examples that use "export default class Foo" statements.
Current coverage is 100% (diff: 100%)@@ master #586 diff @@
====================================
Files 118 118
Lines 1871 1871
Methods 0 0
Messages 0 0
Branches 0 0
====================================
Hits 1871 1871
Misses 0 0
Partials 0 0
|
levithomason
commented
Oct 3, 2016
| @@ -72,6 +72,7 @@ config = Object.assign({}, config, { | |||
| 'brace/mode/html', | |||
| 'brace/theme/tomorrow', | |||
| 'classnames', | |||
| 'copy-to-clipboard', | |||
There was a problem hiding this comment.
This moves copy clipboard to the vendor dll bundle. The dll bundle is used for files that change rarely. It makes watch mode rebuilds of the primary app code much faster.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added copy text confirmation, link to edit the example on GitHub, link to add a bug on GitHub. The bug button prefills the issue template with the relevant information as well: