BREAKING CHANGE: refactor labeled Button API
#616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
levithomason
commented
Oct 4, 2016
| @@ -144,7 +144,7 @@ export default class ComponentExample extends Component { | |||
| .map(l => { | |||
| const defaultImport = _.get(/import\s+(\w+)/.exec(l), '[1]') | |||
| const destructuredImports = _.get(/import.*({[\s\w,}]+)\s+from/.exec(l), '[1]') | |||
| const module = _.snakeCase(_.get(/import.*from.*'(.*)'/.exec(l), '[1]', '')).toUpperCase() | |||
| const module = _.snakeCase(_.get(/import.*from\s+['"]([\w\-_]+)/.exec(l), '[1]', '')).toUpperCase() | |||
There was a problem hiding this comment.
Would like tests for this someday. This fixes the module name detection RegEx, the previous was too permissive and captured too much.
Current coverage is 100% (diff: 100%)@@ master #616 diff @@
====================================
Files 119 119
Lines 1915 1915
Methods 0 0
Messages 0 0
Branches 0 0
====================================
Hits 1915 1915
Misses 0 0
Partials 0 0
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #510
This PR makes the Button
labeledAPI consistent with the InputlabeledAPI. Previously, a Button could be used as alabeled buttonwrapper with another Button/Label child. Now:labeledis nowlabelPositionlabelprop to pass the Label.Fixes #612
It also fixes a recent regression, renderinglabeledButtons as<button>tags. You cannot nest a<button>in a<button>, the labeled button must be adivso it can contain a Label and a Button (<button>) component.This did not account for
labelPositionwith anicon. In that case, a<button>can contain an<i />. Adivis only required when there is alabel. A fix commit has been made to master, TechnologyAdvice/stardust@3379aa5, and will be included in this release.