Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(customPropTypes): itemsShorthand -> collectionShorthand #632

Merged
merged 1 commit into from
Oct 6, 2016

Conversation

levithomason
Copy link
Member

@levithomason levithomason commented Oct 6, 2016

This prop type checker was renamed in all components, but the customPropType method itself somehow remained with the old name. Fixes these issues:

image

Where:

    /** Shorthand array of props for Menu. */
    items: customPropTypes.collectionShorthand,

@levithomason
Copy link
Member Author

/cc @jcarbo can you double check me here, am I renaming this in the right direction or should the components have been updated? From the latest PR comments at #618 I think this is correct.

@jeffcarbs
Copy link
Member

You're right. Not sure how I missed that.

@levithomason
Copy link
Member Author

No worries, you and I both ;)

@levithomason levithomason merged commit 87bf33c into master Oct 6, 2016
@levithomason levithomason deleted the fix/collection-shorthand branch October 6, 2016 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants