Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(build): simplify and fix hmr #821

Merged
merged 2 commits into from
Nov 10, 2016
Merged

Conversation

levithomason
Copy link
Member

@levithomason levithomason commented Nov 10, 2016

I'm beginning to address some of the build issues. This PR:

  • Fixes hot module reloading, the doc site actually reloads properly in dev now 🎉
  • trims the install footprint by removing unnecessary react and babel plugins
  • rewrites the gulpfile and tasks to plain node, no babel-register precompile

@codecov-io
Copy link

Current coverage is 100% (diff: 100%)

Merging #821 into master will not change coverage

@@           master   #821   diff @@
====================================
  Files         136    136          
  Lines        2205   2205          
  Methods         0      0          
  Messages        0      0          
  Branches        0      0          
====================================
  Hits         2205   2205          
  Misses          0      0          
  Partials        0      0          

Powered by Codecov. Last update 29af4a0...2a4116a

@levithomason
Copy link
Member Author

@Semantic-Org/react-collaborators Aside from this PR, I also pushed some updates that affect how dependencies work. I suggest you rm -rf node_modules && npm i to get a fresh install. Not only are packages different, but the tree needs to be flattened for some of them.

@levithomason levithomason merged commit 436e856 into master Nov 10, 2016
@levithomason levithomason deleted the chore/simplify-build branch November 10, 2016 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants