fix(Dropdown|Label): Remove overzealous prop validations

[jeffcarbs]

Fixes #827

[codecov-io]

Current coverage is 100% (diff: 100%)

No coverage report found for master at c957bf2.

Powered by Codecov. Last update c957bf2...de40c7e

[jeffcarbs]

@levithomason - this fixes an annoying/incorrect prop validation warning in Dropdown and Label (see discussion in #827). A quick turnaround on this would be appreciated 😄

Aside from the demand(['onRemove']) warning, having a default for removeIcon also caused a warning in customPropTypes.itemShorthand via disallow([children]). I added a TODO comment so we can possible address in the future and for now just manually specified oneOf(object|node) which we're doing in Dropdown and Search.

[levithomason]

Hm, I read up on this but I think this fix should be to the default and not the validation. My reasoning is that the removeIcon prop is not valid with children, so defaulting a value means we're forcing a conflict when children are used.

I would think then that the issue is that there should not be a default, since having one would break certain use cases. Let me know your thoughts on this.

[levithomason]

I believe this test would still apply since there is a default icon, it is just not applied in defaultProps, true?

[jeffcarbs]

I would think then that the issue is that there should not be a default, since having one would break certain use cases. Let me know your thoughts on this.

As per this comment, I removed the default entirely so you'd have to pass the removeIcon in addition to onRemove. That does seem a little redundant though since the 99% use-case would be to have the removeIcon be delete. I'll add it back and add the test. I'll just use:

const removeIconShorthand = _.isUndefined(removeIcon) ? 'delete' : removeIcon

[jeffcarbs]

Ok this should be g2g :)

[levithomason]

Released in semantic-ui-react@0.60.4.