fix(Input): spread input props on the input child #916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 100% (diff: 100%)@@ master #916 diff @@
====================================
Files 137 137
Lines 2259 2262 +3
Methods 0 0
Messages 0 0
Branches 0 0
====================================
+ Hits 2259 2262 +3
Misses 0 0
Partials 0 0
|
|
Released in |
Arthelon
pushed a commit
to Arthelon/Semantic-UI-React
that referenced
this pull request
Nov 23, 2016
* docs(Input): update children usage * fix(Input): spread input props on the input child
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #909
This PR spreads props on the
inputchild when using children in advanced input variations. It also updates the docs, hoisting all<input />props to the<Input />parent.I've spread the props so that the
inputchild props win, for backward compatibility. Though, the suggested use here is to use theinputchild as a placeholder, without props. I've updated the docs to reflect this as well.