feat(Checkbox|FormField) support label shorthand

[layershifter]

Addresses part of #939.

This PR:

• cleanups components and tests code;
• adds docs about label shorthand;
• improves label shorthand for Checkbox and FormField components.

[codecov-io]

Current coverage is 100% (diff: 100%)

Merging #967 into master will not change coverage

@@           master   #967   diff @@
====================================
  Files         137    137          
  Lines        2283   2281     -2   
  Methods         0      0          
  Messages        0      0          
  Branches        0      0          
====================================
- Hits         2283   2281     -2   
  Misses          0      0          
  Partials        0      0          

Powered by Codecov. Last update ac40713...f308274

[levithomason]

Is this meant to be uncommented or removed?

[layershifter]

Looks like cruft.

[levithomason]

We're listing each shorthand as separate examples. Ideally, shorthand examples immediately follow the example showing the regular usage. I think we should split this into two examples and show them immediately after the first Checkbox example:

[levithomason]

Though this solves the Checkbox usage, I don't see the FormField updates as the title states.

[levithomason]

I'm thinking if a user does this:

<Form.Field label={<MyLabel />} control={<MyControl />} />
<Form.Field label={{ children: 'Name' }} control={<input name='name' />} />

That we should pass that ^ value through the factory as well. Currently, we assume it is a string and render it nested in a <label />.

We can do this on another PR if you like and just leave this one to the Checkbox label updates. LMK.

[layershifter]

I've added updates for FormField and splited shorthand examples 👍

[layershifter]

We can do this on another PR if you like and just leave this one to the Checkbox label updates. LMK.

I think we don't need touch control in this PR.

[levithomason]

Awesome work, thanks :D

I updated the PR description to not close #939 since the PR adding shorthand to the FormField label should close that one.

[layershifter]

Hm... It seems there happened misunderstanding.

---

This PR improved label shorthand on Checkbox and FormField, but didn't touch control shorthand on FormField. Now we can to do this:

<FormField label='my label' />
<FormField label={123} />
<FormField label={{ children: 'foo' }} />
<FormField label={<div className='label' />} />
<FormField label={<MyComponent />} />

But, we can't do this:

<FormField control={<input name='name' />} />

In this case control shorthand will go to this branch and will fail due createElement :)

So, I think #939 can be closed, but we need to open new issue about control shorthand improvement.

[levithomason]

Indeed, thanks for clarifying. I've closed the other issue.