-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(Popup): make allowed content types statically analyzable #990
Conversation
@@ -21,7 +21,6 @@ const _meta = { | |||
name: 'Popup', | |||
type: META.TYPES.MODULE, | |||
props: { | |||
content: [PropTypes.string, PropTypes.node], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also this looked to be in error, since it is not an enum but a propType.
Current coverage is 99.73% (diff: 100%)@@ master #990 diff @@
==========================================
Files 140 140
Lines 2304 2304
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 2298 2298
Misses 6 6
Partials 0 0
|
Yikes, thanks. Since
|
Good call, was not even paying attention to the types to be honest. Patch incoming. |
Pushed and renamed commit accordingly |
Thanks will merge on pass. |
Released in |
This is presumably an issue with all
propType
definitions that reuse propTypes defined in another variable. I traced it down toreact-docgen
being unable to parse the union type because it viewed it as dynamic, which is technically true because that type definition is referenced from a variable and as such the propType is resolved at runtime.Before
After