Skip to content

Commit

Permalink
fix chromedriver download (#570)
Browse files Browse the repository at this point in the history
Co-authored-by: jayant.fegade <jayant.fegade@connectwise.com>
  • Loading branch information
jayph88 and jayant-fegade committed Sep 1, 2023
1 parent 6b7d03f commit 49dc751
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 2 deletions.
2 changes: 1 addition & 1 deletion webdriver_manager/core/os_manager.py
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ class OSType(object):

PATTERN = {
ChromeType.CHROMIUM: r"\d+\.\d+\.\d+",
ChromeType.GOOGLE: r"\d+\.\d+\.\d+(\.\d+)?",
ChromeType.GOOGLE: r"\d+\.\d+\.\d+",
ChromeType.MSEDGE: r"\d+\.\d+\.\d+",
"brave-browser": r"\d+\.\d+\.\d+(\.\d+)?",
"firefox": r"(\d+.\d+)",
Expand Down
7 changes: 6 additions & 1 deletion webdriver_manager/drivers/chrome.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
from webdriver_manager.core.driver import Driver
from webdriver_manager.core.logger import log
from webdriver_manager.core.os_manager import ChromeType
import json


class ChromeDriver(Driver):
Expand Down Expand Up @@ -53,7 +54,11 @@ def get_browser_type(self):
def get_latest_release_version(self):
determined_browser_version = self.get_browser_version_from_os()
log(f"Get LATEST {self._name} version for {self._browser_type}")
if determined_browser_version is not None and version.parse(determined_browser_version) >= version.parse("113"):
if determined_browser_version is not None and version.parse(determined_browser_version) >= version.parse("115"):
url = "https://googlechromelabs.github.io/chrome-for-testing/latest-patch-versions-per-build.json"
response = self._http_client.get(url)
response_dict = json.loads(response.text)
determined_browser_version = response_dict.get("builds").get(determined_browser_version).get("version")
return determined_browser_version
# Remove the build version (the last segment) from determined_browser_version for version < 113
determined_browser_version = ".".join(determined_browser_version.split(".")[:3])
Expand Down

0 comments on commit 49dc751

Please sign in to comment.