Require Rust 1.62 for enum defaults #251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewhassan
reviewed
Jun 1, 2023
There was a problem hiding this comment.
Thanks for doing this! I noticed some spots where it wasn't updated. Should we update them here too for consistency? Or are you only requiring it in functions that need it?
checkout/rust/cart-checkout-validation/default/Cargo.toml.liquidcheckout/rust/cart-transform/default/Cargo.toml.liquidcheckout/rust/payment-customization/default/Cargo.toml.liquiddiscounts/rust/order-discounts/fixed-amount/Cargo.tomldiscounts/rust/product-discounts/fixed-amount/Cargo.tomldiscounts/rust/shipping-discounts/fixed-amount/Cargo.toml
All our examples use codegen from `graphql_client_codegen` which uses [enum defaults][1] which are only [supported as of 1.62][2]. This commit makes that requirement explicit for a more helpful error message: > $ cargo build > error: package [..] ([.. path..]])` cannot be built because it > requires rustc 1.62.0 or newer, while the currently active rustc > version is 1.61.0 [1]: https://github.com/graphql-rust/graphql-client/blob/33b8a34aabbaaac9977a93763ae445dc64b5c67c/graphql_client_codegen/src/deprecation.rs#L10-L20 [2]: rust-lang/rust#94457 (comment)
Of course we should, thanks for noticing. I don't know why but Anyways, fixed! |
jbourassa
force-pushed
the
jb/minimum-rust-version
branch
from
88856dd
to
6dbd1c7
Compare
andrewhassan
approved these changes
Jun 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All our examples use codegen from
graphql_client_codegenwhich uses enum defaults which are only supported as of 1.62.This commit makes that requirement explicit for a more helpful error message: