Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump rubocop from 1.63.4 to 1.66.1 #659

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 8 additions & 10 deletions Gemfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@ GEM
language_server-protocol (3.17.0.3)
method_source (1.0.0)
minitest (5.25.1)
parallel (1.24.0)
parser (3.3.1.0)
parallel (1.26.3)
parser (3.3.5.0)
ast (~> 2.4.1)
racc
pry (0.14.2)
Expand All @@ -26,23 +26,21 @@ GEM
pry-byebug (3.10.1)
byebug (~> 11.0)
pry (>= 0.13, < 0.15)
racc (1.7.3)
racc (1.8.1)
rainbow (3.1.1)
rake (13.2.1)
regexp_parser (2.9.0)
rexml (3.2.6)
rubocop (1.63.4)
regexp_parser (2.9.2)
rubocop (1.66.1)
json (~> 2.3)
language_server-protocol (>= 3.17.0)
parallel (~> 1.10)
parser (>= 3.3.0.2)
rainbow (>= 2.2.2, < 4.0)
regexp_parser (>= 1.8, < 3.0)
rexml (>= 3.2.5, < 4.0)
rubocop-ast (>= 1.31.1, < 2.0)
regexp_parser (>= 2.4, < 3.0)
rubocop-ast (>= 1.32.2, < 2.0)
ruby-progressbar (~> 1.7)
unicode-display_width (>= 2.4.0, < 3.0)
rubocop-ast (1.31.3)
rubocop-ast (1.32.3)
parser (>= 3.3.1.0)
ruby-progressbar (1.13.0)
unicode-display_width (2.5.0)
Expand Down
42 changes: 38 additions & 4 deletions test/fixtures/full_config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,7 @@ AllCops:
DisplayStyleGuide: false
StyleGuideBaseURL: https://shopify.github.io/ruby-style-guide/
DocumentationBaseURL: https://docs.rubocop.org/rubocop
DocumentationExtension: ".html"
ExtraDetails: false
StyleGuideCopsOnly: false
EnabledByDefault: false
Expand All @@ -86,6 +87,7 @@ AllCops:
- rails
rubocop-rspec:
- rspec
- rspec-rails
rubocop-minitest:
- minitest
rubocop-sequel:
Expand All @@ -102,6 +104,7 @@ AllCops:
rubocop-rspec_rails:
- rspec-rails
ActiveSupportExtensionsEnabled: false
StringLiteralsFrozenByDefault:
Bundler/DuplicatedGem:
Description: Checks for duplicate gem entries in Gemfile.
Enabled: true
Expand Down Expand Up @@ -182,6 +185,14 @@ Bundler/OrderedGems:
- "**/*.gemfile"
- "**/Gemfile"
- "**/gems.rb"
Gemspec/AddRuntimeDependency:
Description: Prefer `add_dependency` over `add_runtime_dependency`.
StyleGuide: "#add_dependency_vs_add_runtime_dependency"
Reference: https://github.com/rubygems/rubygems/issues/7799#issuecomment-2192720316
Enabled: pending
VersionAdded: '1.65'
Include:
- "**/*.gemspec"
Gemspec/DependencyVersion:
Description: Requires or forbids specifying gem dependency versions.
Enabled: false
Expand Down Expand Up @@ -1885,8 +1896,7 @@ Lint/UselessAssignment:
Enabled: true
AutoCorrect: contextual
VersionAdded: '0.11'
VersionChanged: '1.61'
SafeAutoCorrect: false
VersionChanged: '1.66'
Lint/UselessElseWithoutRescue:
Description: Checks for useless `else` in `begin..end` without `rescue`.
Enabled: true
Expand All @@ -1899,6 +1909,10 @@ Lint/UselessMethodDefinition:
VersionAdded: '0.90'
VersionChanged: '1.61'
Safe: false
Lint/UselessNumericOperation:
Description: Checks for useless numeric operations.
Enabled: pending
VersionAdded: '1.66'
Lint/UselessRescue:
Description: Checks for useless `rescue`s.
Enabled: true
Expand Down Expand Up @@ -1958,8 +1972,9 @@ Metrics/BlockNesting:
StyleGuide: "#three-is-the-number-thou-shalt-count"
Enabled: true
VersionAdded: '0.25'
VersionChanged: '0.47'
VersionChanged: '1.65'
CountBlocks: false
CountModifierForms: false
Max: 3
Metrics/ClassLength:
Description: Avoid classes longer than 100 lines of code.
Expand Down Expand Up @@ -2339,6 +2354,7 @@ Style/AccessModifierDeclarations:
- inline
- group
AllowModifiersOnSymbols: true
AllowModifiersOnAttrs: true
SafeAutoCorrect: false
Style/AccessorGrouping:
Description: Checks for grouping of accessors in `class` and `module` bodies.
Expand Down Expand Up @@ -2734,6 +2750,7 @@ Style/DocumentationMethod:
Description: Checks for missing documentation comment for public methods.
Enabled: false
VersionAdded: '0.43'
AllowedMethods: []
Exclude:
- "/spec/**/*"
- "/test/**/*"
Expand Down Expand Up @@ -3041,6 +3058,7 @@ Style/HashSyntax:
- never
- either
- consistent
- either_consistent
UseHashRocketsWithSymbolValues: false
PreferHashRocketsForNonAlnumEndingSymbols: false
Style/HashTransformKeys:
Expand Down Expand Up @@ -3815,6 +3833,10 @@ Style/RedundantInterpolation:
SafeAutoCorrect: false
VersionAdded: '0.76'
VersionChanged: '1.30'
Style/RedundantInterpolationUnfreeze:
Description: Checks for redundant unfreezing of interpolated strings.
Enabled: pending
VersionAdded: '1.66'
Style/RedundantLineContinuation:
Description: Check for redundant line continuation.
Enabled: true
Expand Down Expand Up @@ -3977,6 +3999,13 @@ Style/Send:
StyleGuide: "#prefer-public-send"
Enabled: false
VersionAdded: '0.33'
Style/SendWithLiteralMethodName:
Description: Detects the use of the `public_send` method with a static method name
argument.
Enabled: pending
Safe: false
AllowSend: true
VersionAdded: '1.64'
Style/SignalException:
Description: Checks for proper usage of fail and raise.
StyleGuide: "#prefer-raise-over-fail"
Expand Down Expand Up @@ -4125,6 +4154,11 @@ Style/StructInheritance:
SafeAutoCorrect: false
VersionAdded: '0.29'
VersionChanged: '1.20'
Style/SuperArguments:
Description: Call `super` without arguments and parentheses when the signature is
identical.
Enabled: pending
VersionAdded: '1.64'
Style/SuperWithArgsParentheses:
Description: Use parentheses for `super` with arguments.
StyleGuide: "#super-with-args"
Expand Down Expand Up @@ -4156,7 +4190,7 @@ Style/SymbolProc:
Enabled: true
Safe: false
VersionAdded: '0.26'
VersionChanged: '1.40'
VersionChanged: '1.64'
AllowMethodsWithArguments: false
AllowedMethods:
- define_method
Expand Down
Loading