Make sure AR Trilogy adpater does not modify input (#474)

Shopify · Feb 13, 2023 · 6e332f9 · 6e332f9
1 parent 98d8601
commit 6e332f9
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/lib/semian/activerecord_trilogy_adapter.rb b/lib/semian/activerecord_trilogy_adapter.rb
@@ -33,6 +33,7 @@ module ActiveRecordTrilogyAdapter
 
     def initialize(*options)
       *, config = options
+      config = config.dup
       @raw_semian_options = config.delete(:semian)
       @semian_identifier = begin
         name = semian_options && semian_options[:name]

diff --git a/test/adapters/activerecord_trilogy_adapter_test.rb b/test/adapters/activerecord_trilogy_adapter_test.rb
@@ -59,6 +59,15 @@ def test_semian_can_be_disabled
         assert_instance_of(Semian::UnprotectedResource, resource)
       end
 
+      def test_adapter_does_not_modify_config
+        config = @configuration.merge(config_overrides)
+
+        assert(config.key?(:semian))
+        TrilogyAdapter.new(config)
+
+        assert(config.key?(:semian))
+      end
+
       def test_unconfigured
         adapter = trilogy_adapter(
           host: SemianConfig["toxiproxy_upstream_host"],