Update comment for Semian.register method #425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miry
force-pushed
the
semian-docs-for-register
branch
2 times, most recently
from
cd39466
to
a00c124
Compare
miry
force-pushed
the
semian-docs-for-register
branch
from
a00c124
to
2073359
Compare
casperisfine
approved these changes
Oct 10, 2022
yongli-shopify
approved these changes
Oct 11, 2022
Add doc for missing options error_threshold_timeout and error_threshold_timeout_enabled to the method `Semian.register` comment. Co-authored-by: Jean byroot Boussier <jean.boussier+github@shopify.com>
miry
force-pushed
the
semian-docs-for-register
branch
from
5e4f894
to
e596bd9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add doc for missing options error_threshold_timeout and error_threshold_timeout_enabled to the method
Semian.registercomment.