Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove query of ENV on each circuit breaker acquire. #427

Merged
merged 1 commit into from
Nov 15, 2022
Merged

Remove query of ENV on each circuit breaker acquire. #427

merged 1 commit into from
Nov 15, 2022

Commits on Nov 14, 2022

  1. Found that there is checking on ENV variable on each acquire invoking… 

    … method.

Move logic of disabled? for Circuit breaker to Initalization part.
Circtuit breaker should have any knowledge of ENV or configurations.

Update using of SEMIAN_DISABLED to disable Semian without creating any resources.

It would allow only check only once if CircuitBreaker exists in resource acquire.
If there is any of ENV `SEMIAN_CIRCUIT_BREAKER_DISABLED` or `SEMIAN_DISABLED` exists,
then it would disable Circuit breaker initialization.
    @miry
    miry committed Nov 14, 2022
    Configuration menu
    Copy the full SHA
    fe813e8 View commit details
    Browse the repository at this point in the history