Remove unsupported way to run callbacks on signal #464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miry
requested review from
a team,
neufeldtech,
QuantumManiac and
keldin-coding
and removed request for
a team
In tests used lru clean table with Mutex in fork process on exit. It is not supported anymore and could be removed https://bugs.ruby-lang.org/issues/14222. Sample exception: ``` Class: ThreadError Message: can't be called from trap context ---Backtrace--- lib/semian/lru_hash.rb:110:in `synchronize' lib/semian/lru_hash.rb:110:in `delete' lib/semian.rb:231:in `unregister' test/resource_test.rb:67:in `block in test_unregister_past_0' ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In tests used lru clean table with Mutex in fork process on exit.
It is not supported anymore and could be removed https://bugs.ruby-lang.org/issues/14222.
Sample exception:
Could not run
semian/lib/semian/lru_hash.rb
Line 110 in e1252f5
Signal.trap.