Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AR Trilogy Adapter: Handle AdapterTimeout and ConnectionFailed errs #497

Merged
merged 2 commits into from
Jun 1, 2023
Merged

AR Trilogy Adapter: Handle AdapterTimeout and ConnectionFailed errs #497

merged 2 commits into from
Jun 1, 2023

Commits on May 31, 2023

  1. Update AR trilogy lockfile

    @adrianna-chang-shopify
    adrianna-chang-shopify committed May 31, 2023
    Configuration menu
    Copy the full SHA
    479e49a View commit details
    Browse the repository at this point in the history

Commits on Jun 1, 2023

  1. AR Trilogy Adapter: Handle AdapterTimeout and ConnectionFailed errs 

    This commit ensures that ActiveRecord::AdapterTimeout errors are
handled for the AR Trilogy Adapter. As of rails/rails@785f656,
TimeoutErrors are translated to AdapterTimeout errors in Rails. As such,
we no longer need special handling in `#acquire_semian_resource` for
such errors.

This commit also ensures that ActiveRecord::ConnectionFailed errors are
classified as resource exceptions. These are network-related exceptions
and should be handled by Semian.
    @adrianna-chang-shopify
    adrianna-chang-shopify committed Jun 1, 2023
    Configuration menu
    Copy the full SHA
    121a194 View commit details
    Browse the repository at this point in the history