Fix invalid JSON in /version endpoint response (#538)

* Fix invalid JSON in /version endpoint response * Fix test
Shopify · Oct 25, 2023 · c3d8bf6 · c3d8bf6
1 parent 3399ea0
commit c3d8bf6
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/api.go b/api.go
@@ -477,7 +477,7 @@ func (server *ApiServer) Version(response http.ResponseWriter, request *http.Req
 	log := zerolog.Ctx(request.Context())
 
 	response.Header().Set("Content-Type", "application/json;charset=utf-8")
-	version := fmt.Sprintf(`{"version": "%s"}\n`, Version)
+	version := fmt.Sprintf("{\"version\": \"%s\"}\n", Version)
 	_, err := response.Write([]byte(version))
 	if err != nil {
 		log.Warn().Err(err).Msg("Version: Failed to write response to client")

diff --git a/api_test.go b/api_test.go
@@ -1103,7 +1103,7 @@ func TestVersionEndpointReturnsVersion(t *testing.T) {
 			t.Fatal("Unable to read body from response")
 		}
 
-		if string(body) != `{"version": "git"}\n` {
+		if string(body) != "{\"version\": \"git\"}\n" {
 			t.Fatal("Expected to return Version from /version, got:", string(body))
 		}
 	})