E2E tests #309
Merged
E2E tests #309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miry
force-pushed
the
bennchmarking-testing
branch
4 times, most recently
from
9b0ade6
to
459924e
Compare
thepwagner
approved these changes
Sep 7, 2021
There was a problem hiding this comment.
LGTM!
I wondered about using docker-compose to manage these instead:
wait_for_urllooks a lot like a dockerHEALTHCHECKtrap pkill ; pkillis a little likedocker-compose down -f- the pattern of prefixing log output from the
[web]and[toxiproxy] servers with sed is also ~free in docker-compose
I'm not sold it's worth adding the extra dependency, just noting the similarities.
miry
force-pushed
the
bennchmarking-testing
branch
from
459924e
to
c149d35
Compare
|
@thepwagner Thank you for your review and feedback. You are right about |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add script to run e2e tests to test client and server.
Use benchmarking script as sample client application.
Automate the process with Github Actions in test workflow.