Extract client flags specs to seperate methods #321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miry
added a commit
that referenced
this pull request
Sep 17, 2021
miry
added a commit
that referenced
this pull request
Sep 17, 2021
miry
force-pushed
the
client-extract-methods
branch
4 times, most recently
from
4f9c70a
to
d062d0d
Compare
Make sure the main function is not overhelming, extract portion of lines to separate methods for better read. Found that client in `toxic add` supports both: `--upstream` and `--downstream`. Because it tries to create 2 toxic with single name it produces the error when tries add `--downstream` toxic, and in same time creates the `--upstream` toxic. To remove confusion update the client usage help to support only one in same time. Return error message in case 2 flags provided.
miry
force-pushed
the
client-extract-methods
branch
from
18d56b9
to
0bed9b0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure the main function is not overhelming,
extract portion of lines to separate methods for better read.
Found that client in
toxic addsupports both:--upstreamand--downstream. Because it tries to create 2 toxic with single name itproduces the error when tries add
--downstreamtoxic, and in same timecreates the
--upstreamtoxic.Update the usage help to mention about argument
--toxicity <float>To remove confusion update the client usage help to support only one in
same time. Return error message in case 2 flags provided.
Introduce a new way to add toxics with client:
Provide a structure
ToxicOptionswith all required options and pass toclient.AddToxicto add toxic.