fix: The release-test task is always success #340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miry
force-pushed
the
update_release_test
branch
from
2153a41
to
3c7aa22
Compare
miry
changed the title
…ess. It seems the task release-test always was success, because the variables were not used in the strings. Extract code from Makefile to make it easy to run single tests and in same time to keep using only bash.
miry
force-pushed
the
update_release_test
branch
from
3c7aa22
to
0d104df
Compare
neufeldtech
approved these changes
Nov 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a make task to check binaries correctnes that is always success.
It seems the task release-test always was success, because the variables were not
used in the strings.
Extract code from Makefile to make it easy to run single tests
and in same time to keep using only bash.
Also add posibility to run task on arm machines.