-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kyocera printer support #79
Conversation
And BTW: I like the way how you add that separate build step ❤️ Thanks for your contribution in the name of the growing community around this container. |
dbfc663
to
90397fa
Compare
Hmm, the failed checks look more like an issue with the pipeline to me? The error doesn't sound like anything that is related to my changes. |
Yes, I need to look into that, it's the first time the pipeline runs on a forked PR, so maybe sth is missing. |
Yeah, it's the circle-CI environment variables which your pipeline does not get access to. I'll make the build vars public, the only thing really secret is required only for pushing the image. |
If you rebase now, the pipelines should succeed. |
90397fa
to
7391e3f
Compare
seems like your build step fails for at least one arch. Maybe you want to add an option to skip this for arm?
|
try putting in a build step for Kyocera for both platforms, where the one for ARM is basically a no-op build step (not adding Kyocera support) For reference: docker/cli#1134 (comment) |
Yeah looks good from what I can tell, I inspected the x86 image locally and it's got all the files in the correct places. Failing build now is just because it's not allowed to push. |
Not sure if this is something that should be in the main repo, but I'll still add it here.
Kyocera printers right now are a massive pain to get working, but thanks to Fe-Ti/rastertokpsl-re and the PR from eLtMosen it's possible.
This PR clones & builds the fixed Kyocera printer drivers and then adds them to the final image. After that my FS-1041 just worked.
Docker image of this is available here