Feat: logspipelineprocessor: read/address body fields in pipeline operators directly if body is json #416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ribute that gets ignored when converting back to plog
…t of JSON body fields
raj-k-singh
force-pushed
the
feat/logspipelineprocessor-address-body-fields-directly-if-body-is-json
branch
from
7fb98ca
to
3fae4f0
Compare
srikanthccv
previously approved these changes
Oct 9, 2024
…ds-directly-if-body-is-json
srikanthccv
approved these changes
Oct 10, 2024
raj-k-singh
deleted the
feat/logspipelineprocessor-address-body-fields-directly-if-body-is-json
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes https://github.com/SigNoz/engineering-pod/issues/1582
This PR brings in a copy of body_field.go from opentelemetry-collector-contrib stanza and modifies it to allow reading from fields inside bodies containing JSON text
To use this custom body field, this PR also brings in a copy of field.go from otel collector contrib stanza and modifies it to unmarshal body field references into our custom body field copy
Operator configs have also been updated to use signozstanzaentry.Field instead of entry.Field to enable reading from body JSON.
To achieve this, the PR also brings in copies of stanza helpers used for defining operator configs - for eg: parser.go.
Some helper dependencies were in "internal" packages and had to be copied over too for use here - eg: ctimefmt.go
All files that have been copied over have comments at the top of the file indicating the same and mentioning any changes that have been made.