Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update logs fingerprint #417

Merged
merged 1 commit into from
Oct 8, 2024
Merged

Conversation

nityanandagohain
Copy link
Member

Have added env and component to the hierarchy.

@raj-k-singh also env's are subhierarchy of service.name, should we keep it this way ? ideally service should be a subhierarchy of env right

@raj-k-singh
Copy link
Contributor

Have added env and component to the hierarchy.

@raj-k-singh also env's are subhierarchy of service.name, should we keep it this way ? ideally service should be a subhierarchy of env right

As per otel semantic conventions, envs are a subset of a service i.e. staging & prod resources for a service still come under the same service in the semantic conventions hierarchy
https://opentelemetry.io/docs/specs/semconv/resource/deployment-environment/#:~:text=This%20implies%20that%20resources%20carrying%20the%20following%20attribute%20combinations%20MUST%20be%20considered%20to%20be%20identifying%20the%20same%20service

@nityanandagohain
Copy link
Member Author

Ahh okay, thanks 👍

@nityanandagohain nityanandagohain merged commit f109e00 into main Oct 8, 2024
3 checks passed
@nityanandagohain nityanandagohain deleted the fix/logs-fingerprint branch October 8, 2024 09:45
@ankitnayan
Copy link
Contributor

Have added env and component to the hierarchy.
@raj-k-singh also env's are subhierarchy of service.name, should we keep it this way ? ideally service should be a subhierarchy of env right

Let's discuss more in the standup. This might not be the ideal user interaction. I do not see service as a superset. User would like to choose an environment and then see the list of health of services rather than the other way round

@raj-k-singh
Copy link
Contributor

Have added env and component to the hierarchy.
@raj-k-singh also env's are subhierarchy of service.name, should we keep it this way ? ideally service should be a subhierarchy of env right

Let's discuss more in the standup. This might not be the ideal user interaction. I do not see service as a superset. User would like to choose an environment and then see the list of health of services rather than the other way round

I am not sure of the exact reasons behind the semantic conventions.
If I had to guess, it is because a service typically exists in a service oriented architecture, and service oriented architectures are ideally about scaling an engg org though teams, where 1 service is run by 1 team. So a typical team would own all environments for a single service and would see the hierarchy as service -> env
I can also understand how "microservices" architectures might end up with many many services per team in which case a typical team/engg would want to look for many services in a particular environment and see the hierarchy as env -> service

From the DB perf perspective, I am guessing both organizations would be performant enough and we can choose whatever we want

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants