Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

collector processors generated for Log pipelines should not be async #4444

Closed
raj-k-singh opened this issue Jan 28, 2024 · 1 comment
Closed

collector processors generated for Log pipelines should not be async #4444

raj-k-singh opened this issue Jan 28, 2024 · 1 comment
Assignees
@raj-k-singh
Labels
log pipelines logs

Comments

@raj-k-singh
Copy link
Collaborator

raj-k-singh commented Jan 28, 2024 •
edited
Loading

Logs pipelines in the UI get translated to logstransform processors right now.
logstransform processors are async and do their own internal batching. This makes the entire collector pipeline async - consumeLogs at the receiver returns before it is guaranteed that the exporter has finished exporting logs.
Having sync collector pipelines makes it simpler to provide persistence guarantees for logs collected by receivers.
@raj-k-singh raj-k-singh self-assigned this Jan 28, 2024
@request-info Request Info
Copy link

request-info bot commented Jan 28, 2024

We would appreciate it if you could provide us with more info about this issue/pr!

@raj-k-singh raj-k-singh mentioned this issue Jan 29, 2024
Merged
@raj-k-singh raj-k-singh mentioned this issue Feb 14, 2024
Merged
This was referenced Apr 9, 2024
Draft
Merged
@ankitnayan ankitnayan mentioned this issue Jun 29, 2024
Open
34 tasks
@raj-k-singh raj-k-singh mentioned this issue Sep 11, 2024
Merged
raj-k-singh added a commit to SigNoz/signoz-otel-collector that referenced this issue Sep 13, 2024
@raj-k-singh
Signozlogspipelineprocessor: an otel processor dedicated to signoz lo…
9bac5fc 
…gs pipelines (#386)

contributes to SigNoz/signoz#5894 and
SigNoz/signoz#4444
@raj-k-singh raj-k-singh mentioned this issue Sep 16, 2024
Merged
raj-k-singh added a commit to SigNoz/signoz-otel-collector that referenced this issue Sep 19, 2024
@raj-k-singh
Signozlogspipelineprocessor: use own copy of stanza operators (#403)
2d00bb9 
Brings in copies of stanza pieces relevant to logs pipelines from
opentelemetry-collector-config at
processor/signozlogspipelineprocessor/stanza/

Bringing over pieces of stanza will give us the ability to modify
anything and everything as needed to achieve our goals with logs
pipelines

Almost all of the files in this PR have been brought in as is with
no/minimal modifications and have a comment stating the same in their
1st line

contributes to SigNoz/signoz#5894 and
SigNoz/signoz#4444
@raj-k-singh raj-k-singh mentioned this issue Sep 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@raj-k-singh raj-k-singh

Labels
log pipelines logs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@raj-k-singh