Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: new rules & updates #4328

Merged
merged 16 commits into from
Jul 13, 2023
Merged

Conversation

nasbench
Copy link
Member

@nasbench nasbench commented Jun 22, 2023

Summary of the Pull Request

This PR adds new rules and multiple updates

Detailed Description of the Pull Request / Additional Comments

N/A

Example Log Event

N/A

Fixed Issues

N/A

SigmaHQ Rule Creation Conventions

  • If your PR adds new rules, please consider following and applying these conventions

Copy link
Contributor

@w0rk3r w0rk3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this is the way it works when using selection, so feel free to ignore if not relevant

@nasbench
Copy link
Member Author

Not sure if this is the way it works when using selection, so feel free to ignore if not relevant

Still working on this. Just pushed to get things going. Will fix the broken selections later. Cheers 🙏

@nasbench nasbench added the Work In Progress Some changes are needed label Jun 23, 2023
@nasbench nasbench changed the title feat: new rules & update feat: new rules & updates Jun 23, 2023
@nasbench nasbench added Rules Windows Pull request add/update windows related rules and removed Work In Progress Some changes are needed labels Jun 26, 2023
@nasbench nasbench self-assigned this Jun 26, 2023
@nasbench nasbench requested a review from phantinuss June 26, 2023 09:07
@nasbench nasbench marked this pull request as ready for review June 26, 2023 09:07
nasbench and others added 2 commits July 13, 2023 09:17
Co-authored-by: phantinuss <79651203+phantinuss@users.noreply.github.com>
@nasbench nasbench merged commit ccec820 into SigmaHQ:master Jul 13, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Rules Windows Pull request add/update windows related rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants