-
-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to use regex on file path instead of folder templates #974
base: master
Are you sure you want to change the base?
Conversation
n=1 of course, but I've been using these changes without any hick-ups since December |
Is it possible to merge with the main branch? |
We would need @SilentVoid13 for that |
We do actually. It's still useful to pin APIs to specific obsidian versions. There's also scripts and dependencies in there that we'd like to keep updated. Finally, I think Obsidian itself needs the version info in it to install properly. |
Could you remove the changes to .gitignore and vscode configuration, or have a separate MR, so that this feature can be merged faster? @harmtemolder |
Sorry about that. I see that I wrote |
Excuse me, Does the PR have made any new progress? |
The PR was finished a year ago, but I see there are now conflicts because of changes made to the plugin in the time since then. I (or someone else) would need to resolve those before @SilentVoid13 would be able to merge the PR. @SilentVoid13 Are you interested in merging this PR? If so, I'll take the time to resolve the conflicts |
I am interested in seeing this functionality added. If you resolve the conflicts and remove the unrelated changes (such as updating the Ideally, we'd also add unit tests for this, but I don't think it's strictly required, as long as the existing tests still pass. |
@Zachatoo I've solved all conflicts, built and tested with the file regex templates I use in my vault. Those work as expected. Could you explicitly test that this does not break any existing folder templates somebody might be using? I've never written unit tests in TypeScript, but adding those for this functionality sounds like a good idea. Let me know how I can help with that. |
As discussed in #471 the current folder templates do not cover all use cases. Having the option to use regex on the file path of a new file instead should give advanced users the flexibility they seek.
I've kept the folder templates option intact, letting a user pick between the two. Their toggles are linked, so enabling one will disable the other.
I've also updated the docs to match the current layout of the settings window.
And I made two minor changes to
.gitignore
:package-lock.json
, because I don't think we need to lock versions, do we?.vscode/settings.json
, to allow for synching of workspace settings between our VSCodes, specificallyeditor.defaultFormatter
, so that all of use Prettier (and thus the included.prettierrc.json
)