Fix wrong queue size while reading multiple frames. #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Made strings ref-to-const. Removed useless const qualifier for return values. Fixed return type mismatches. Added in-class-initialisers.
waitForMessages() now uses ioctl(FIONREAD) to return the size of the queue.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to an error on my part, a wrong assumption was made about the behaviour of
select().select()returns the number of read file descriptors, instead of the amount of frames ready to be read.This bug is a typical case of not noticing it, because it seem(s/ed) to work.
Thank you for reporting this.
The code in this PR is currently untested.
Once tested, fixes issue 14.