Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Added S3ClientProvider to AWSS3StorageCache and AWSS3StorageImageProvider #362

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

marklagendijk
Copy link
Contributor

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following matches the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

Implementation of #360 for AWS.

S3CannedACL acl)
=> AsyncHelper.RunSync(() => CreateIfNotExistsAsync(options, acl));
S3CannedACL acl,
IServiceProvider serviceProvider)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is a breaking change, because it requires users of this method to add the serviceProvider param.

namespace SixLabors.ImageSharp.Web;

/// <summary>
/// Provides a common interface for AWS S3 Bucket Client Options.
/// </summary>
internal interface IAWSS3BucketClientOptions
public interface IAWSS3BucketClientOptions
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to make the internal interface public here, because it is used as a param of the S3ClientProvider.

@JimBobSquarePants
Copy link
Member

@marklagendijk We've got failing tests here. Could you please have a look?

@JimBobSquarePants
Copy link
Member

I want to avoid breaking changes here or else it's major version update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants