Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update codcov and config #1820

Merged
merged 2 commits into from
Nov 11, 2021
Merged

Update codcov and config #1820

merged 2 commits into from
Nov 11, 2021

Conversation

JimBobSquarePants
Copy link
Member

@JimBobSquarePants JimBobSquarePants commented Nov 11, 2021

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

  • Update coverlet.collector to 3.1.0
  • Use integer precision for coverage calculation.
  • Ignore patch coverage for checks.
  • Use shared codecov.yml config from submodule

@codecov
Copy link

codecov bot commented Nov 11, 2021

Codecov Report

Merging #1820 (3ac8b2b) into master (1997d59) will increase coverage by 0%.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1820   +/-   ##
======================================
  Coverage      87%     87%           
======================================
  Files         936     936           
  Lines       48164   48164           
  Branches     6037    6037           
======================================
+ Hits        41998   42067   +69     
+ Misses       5162    5096   -66     
+ Partials     1004    1001    -3     
Flag Coverage Δ
unittests 87% <ø> (+<1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rc/ImageSharp/Formats/Webp/Lossless/Vp8LEncoder.cs 97% <0%> (+<1%) ⬆️
...ageSharp/Formats/Webp/Lossless/PredictorEncoder.cs 98% <0%> (+5%) ⬆️
.../ImageSharp/Formats/Webp/Lossless/LosslessUtils.cs 97% <0%> (+6%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d74c4c...3ac8b2b. Read the comment docs.

@JimBobSquarePants JimBobSquarePants requested a review from a team November 11, 2021 02:10
Copy link
Member

@antonfirsov antonfirsov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Isn't threshold something that can help us?

@JimBobSquarePants
Copy link
Member Author

Isn't threshold something that can help us?

I don't really want to encourage allowing the percentage to drop. Let's give this a spin first.

@JimBobSquarePants JimBobSquarePants merged commit 21d95a7 into master Nov 11, 2021
@JimBobSquarePants JimBobSquarePants deleted the js/coverlet branch November 11, 2021 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants