Webp improvements #1846
Merged
Webp improvements #1846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1846 +/- ##
======================================
Coverage 87% 87%
======================================
Files 937 937
Lines 48423 48438 +15
Branches 6056 6057 +1
======================================
+ Hits 42225 42317 +92
+ Misses 5192 5114 -78
- Partials 1006 1007 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
| public void Dispose() | ||
| { | ||
| this.Dispose(disposing: true); | ||
| GC.SuppressFinalize(this); |
There was a problem hiding this comment.
If your types can be sealed I would do so and avoid SuppressFinalize where it is not necessary.
There was a problem hiding this comment.
Yeah I think the Dispose(bool disposing) pattern is only favorable when we actually have a finalizer or expect subclasses to have a finalizer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
This PR changes the following:
CostIntervalobjects by pooling a small amount of them. The number ofCostIntervalobjects can easily get into 100k+ for an 1 megapixel image.Related to #1786
Allocations master:
Allocations PR:
Test was done with lossless encoding of Calliphora image.