Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missing CancellationToken parameters to Image #1856

Merged
merged 1 commit into from
Nov 29, 2021

Conversation

justinbhopper
Copy link
Contributor

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

I noticed that a few asynchronous overloaded methods on the Image class were needlessly omitting a CancellationToken parameter when the underlying code supported cancellation. This PR adds the cancel token parameter, but keeps them optional for backwards compatibility.

@CLAassistant
Copy link

CLAassistant commented Nov 28, 2021

CLA assistant check
All committers have signed the CLA.

@JimBobSquarePants JimBobSquarePants added this to the 2.0.0 milestone Nov 29, 2021
@codecov
Copy link

codecov bot commented Nov 29, 2021

Codecov Report

Merging #1856 (c0ee67b) into master (013c29e) will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1856   +/-   ##
======================================
  Coverage      87%     87%           
======================================
  Files         937     937           
  Lines       48727   48727           
  Branches     6094    6094           
======================================
  Hits        42507   42507           
  Misses       5209    5209           
  Partials     1011    1011           
Flag Coverage Δ
unittests 87% <100%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/ImageSharp/Image.FromFile.cs 98% <100%> (ø)
src/ImageSharp/Image.FromStream.cs 83% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 013c29e...c0ee67b. Read the comment docs.

@JimBobSquarePants
Copy link
Member

This is fantastic @justinbhopper Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants