Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AVX2 version of QuantizeBlock #1857

Merged
merged 5 commits into from
Dec 2, 2021
Merged

Add AVX2 version of QuantizeBlock #1857

merged 5 commits into from
Dec 2, 2021

Conversation

brianpopow
Copy link
Collaborator

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

This PR adds a AVX2 version of QuantizeBlock, which is used during lossy webp encoding.

Related to #1786

Profiling results:

master

Quantize_master

PR

Quantize_avx

Test image was Calliphora.png

@codecov
Copy link

codecov bot commented Nov 29, 2021

Codecov Report

Merging #1857 (909525c) into master (f44f11f) will increase coverage by 0%.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #1857    +/-   ##
=======================================
  Coverage      87%     87%            
=======================================
  Files         935     935            
  Lines       48751   48786    +35     
  Branches     6081    6083     +2     
=======================================
+ Hits        42620   42724   +104     
+ Misses       5123    5056    -67     
+ Partials     1008    1006     -2     
Flag Coverage Δ
unittests 87% <100%> (+<1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/ImageSharp/Formats/Webp/Lossy/QuantEnc.cs 96% <100%> (+<1%) ⬆️
...rc/ImageSharp/Formats/Webp/Lossless/Vp8LEncoder.cs 97% <0%> (+<1%) ⬆️
...ImageSharp/Formats/Webp/Lossless/Vp8LBitEntropy.cs 100% <0%> (+1%) ⬆️
.../ImageSharp/Formats/Webp/Lossless/LosslessUtils.cs 98% <0%> (+5%) ⬆️
...ageSharp/Formats/Webp/Lossless/PredictorEncoder.cs 97% <0%> (+6%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f44f11f...909525c. Read the comment docs.

@JimBobSquarePants JimBobSquarePants added this to the 2.0.0 milestone Nov 29, 2021
@JimBobSquarePants JimBobSquarePants requested a review from a team December 1, 2021 13:44
Copy link
Member

@JimBobSquarePants JimBobSquarePants left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@brianpopow brianpopow merged commit 0517fec into master Dec 2, 2021
@brianpopow brianpopow deleted the bp/quantizeblockavx branch December 2, 2021 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants