Add AVX2 version of GetResidualCost and SSE2 version of SetCoeffs #1902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1902 +/- ##
======================================
Coverage 87% 87%
======================================
Files 961 961
Lines 50990 51034 +44
Branches 6319 6324 +5
======================================
+ Hits 44747 44793 +46
Misses 5202 5202
+ Partials 1041 1039 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
brianpopow
commented
Dec 20, 2021
|
|
||
| #if SUPPORTS_RUNTIME_INTRINSICS | ||
| [Fact] | ||
| public void RunEncodeLossy_WithPeakImage_WithHardwareIntrinsics_Works() => FeatureTestRunner.RunWithHwIntrinsicsFeature(RunEncodeLossy_WithPeakImage, HwIntrinsics.AllowAll); |
There was a problem hiding this comment.
Note: I could not figure out how to write a single test for GetResidualCost, it would be rather complicated. Instead i have decided to do lossy encoding test with and without hardware intrinsics
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
This PR adds a AVX2 version of
GetResidualCostand SSE2 version ofSetCoeffs, which is used during webp lossy encoding.Related to #1786
Profiling results:
master
PR
The performance gain from
GetResidualCostis a bit underwhelming, but its not nothing either.