-
-
Notifications
You must be signed in to change notification settings - Fork 851
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose ImageFrame<TPixel>.PixelBuffer #1906
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1906 +/- ##
======================================
- Coverage 87% 87% -1%
======================================
Files 961 961
Lines 50991 50990 -1
Branches 6319 6319
======================================
- Hits 44748 44747 -1
Misses 5202 5202
Partials 1041 1041
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
/// <inheritdoc/> | ||
Buffer2D<TPixel> IPixelSource<TPixel>.PixelBuffer => this.PixelBuffer; | ||
public Buffer2D<TPixel> PixelBuffer { get; private set; } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can <inheritdoc/>
publicly inherit docs from an internal interface?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I honestly have no idea. I think it triggers a copy of the docs though during build rather than reference the original
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, we check it during doc generation, and fix if it doesn't work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Intellisense seems to be working in consuming project.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Prerequisites
Description
We need to expose this property to allow migrating the ImageSharp.Drawing brush API to the latest ImageSharp v2 versions without runtime error.