Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose ImageFrame<TPixel>.PixelBuffer #1906

Merged
merged 1 commit into from
Dec 21, 2021

Conversation

JimBobSquarePants
Copy link
Member

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

We need to expose this property to allow migrating the ImageSharp.Drawing brush API to the latest ImageSharp v2 versions without runtime error.

@JimBobSquarePants JimBobSquarePants added this to the 2.0.0 milestone Dec 21, 2021
@codecov
Copy link

codecov bot commented Dec 21, 2021

Codecov Report

Merging #1906 (981ff69) into master (04f64b6) will decrease coverage by 0%.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1906   +/-   ##
======================================
- Coverage      87%     87%   -1%     
======================================
  Files         961     961           
  Lines       50991   50990    -1     
  Branches     6319    6319           
======================================
- Hits        44748   44747    -1     
  Misses       5202    5202           
  Partials     1041    1041           
Flag Coverage Δ
unittests 87% <100%> (-1%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/ImageSharp/ImageFrame{TPixel}.cs 91% <100%> (-1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04f64b6...981ff69. Read the comment docs.

/// <inheritdoc/>
Buffer2D<TPixel> IPixelSource<TPixel>.PixelBuffer => this.PixelBuffer;
public Buffer2D<TPixel> PixelBuffer { get; private set; }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can <inheritdoc/> publicly inherit docs from an internal interface?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I honestly have no idea. I think it triggers a copy of the docs though during build rather than reference the original

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, we check it during doc generation, and fix if it doesn't work.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Intellisense seems to be working in consuming project.

Copy link
Member

@antonfirsov antonfirsov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@JimBobSquarePants JimBobSquarePants merged commit 4cb36e6 into master Dec 21, 2021
@JimBobSquarePants JimBobSquarePants deleted the js/public-pixelbuffer branch December 21, 2021 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants