Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webp encoder now defaults to lossy, if nothing else is specified #1961

Merged
merged 2 commits into from
Jan 26, 2022

Conversation

brianpopow
Copy link
Collaborator

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

To match libwebp behavior, the Webp encoder now defaults to lossy, if nothing else is specified.

@brianpopow brianpopow added this to the 2.0.0 milestone Jan 26, 2022
Copy link
Member

@JimBobSquarePants JimBobSquarePants left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@brianpopow brianpopow merged commit f15bc74 into master Jan 26, 2022
@brianpopow brianpopow deleted the bp/webplossydefault branch January 26, 2022 11:36
@JimBobSquarePants
Copy link
Member

JimBobSquarePants commented Jan 27, 2022

@brianpopow I'm seeing a lack of alpha channel support when using lossy encoding. Is that expected?

EDIT. Just saw this.
#1802

On a scale of 1 to only you can do it how hard would it be to add support?

@brianpopow
Copy link
Collaborator Author

@brianpopow I'm seeing a lack of alpha channel support when using lossy encoding. Is that expected?

EDIT. Just saw this. #1802

On a scale of 1 to only you can do it how hard would it be to add support?

I dont think its hard to do. The Alpha data just needs to be encoded with the already existing VP8LEncoder or stored as is in an additional ALPH chunk.

@PhyxionNL
Copy link

Until alpha support is added, I'm not sure this is a good default as you'd end up with lots of broken images.

@brianpopow
Copy link
Collaborator Author

I am working on alpha encoding. Should not take too long to implement.

@JimBobSquarePants
Copy link
Member

@brianpopow HERO!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants