-
-
Notifications
You must be signed in to change notification settings - Fork 851
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PNG: Add SSE/AVX version of Sub, Up, Average and Paethfilters #2028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianpopow
changed the title
PNG: Add SSE2 version of average filter
WIP: PNG: Add SSE2 version of average filter
Feb 23, 2022
brianpopow
changed the title
WIP: PNG: Add SSE2 version of average filter
PNG: Add SSE2 version of average filter
Feb 23, 2022
brianpopow
changed the title
PNG: Add SSE2 version of average filter
WIP: PNG: Add SSE2 version of average filter
Feb 23, 2022
brianpopow
changed the title
WIP: PNG: Add SSE2 version of average filter
PNG: Add SSE2 version of average filter
Feb 23, 2022
gfoidl
reviewed
Feb 24, 2022
Co-authored-by: Günther Foidl <gue@korporal.at>
@gfoidl thanks for the suggestions! |
I have added SSE/AVX versions of the other filters, too. Benchmark with random data of size 1024:
|
brianpopow
changed the title
PNG: Add SSE2 version of average filter
PNG: Add SSE/AVX version of Sub, Up, Average and Paethfilters
Feb 25, 2022
JimBobSquarePants
approved these changes
Feb 28, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice improvement!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
This PR adds a SSE2 version of the average filter (4 bytes per pixel only), which is used for decoding PNG's.
I tried a SSE2 version for 3 bytes per pixel also, but benchmarks did not show god results. Probably due to misaligned read/write.
edit:
PR now also includes SSE/AVX versions of Paeth, Sub and Up filter.
Benchmark results:
master:
PR:
Testimage was: