Improved jpeg encoding benchmarks #2051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
br3aker
commented
Mar 9, 2022
Comment on lines
+75
to
+88
| | Method | TargetColorSpace | Quality | Mean | Error | StdDev | | ||
| |---------- |----------------- |-------- |----------:|----------:|----------:| | ||
| | Benchmark | Luminance | 75 | 7.055 ms | 0.1411 ms | 0.3297 ms | | ||
| | Benchmark | Rgb | 75 | 12.139 ms | 0.0645 ms | 0.0538 ms | | ||
| | Benchmark | YCbCrRatio420 | 75 | 6.463 ms | 0.0282 ms | 0.0235 ms | | ||
| | Benchmark | YCbCrRatio444 | 75 | 8.616 ms | 0.0422 ms | 0.0374 ms | | ||
| | Benchmark | Luminance | 90 | 7.011 ms | 0.0361 ms | 0.0301 ms | | ||
| | Benchmark | Rgb | 90 | 13.119 ms | 0.0947 ms | 0.0886 ms | | ||
| | Benchmark | YCbCrRatio420 | 90 | 6.786 ms | 0.0328 ms | 0.0274 ms | | ||
| | Benchmark | YCbCrRatio444 | 90 | 8.672 ms | 0.0772 ms | 0.0722 ms | | ||
| | Benchmark | Luminance | 100 | 9.554 ms | 0.1211 ms | 0.1012 ms | | ||
| | Benchmark | Rgb | 100 | 19.475 ms | 0.1080 ms | 0.0958 ms | | ||
| | Benchmark | YCbCrRatio420 | 100 | 10.146 ms | 0.0585 ms | 0.0519 ms | | ||
| | Benchmark | YCbCrRatio444 | 100 | 15.317 ms | 0.0709 ms | 0.0592 ms | |
There was a problem hiding this comment.
Luminance encoding has same (or even worse) performance as YCbCr 4:2:0 because Rgb24 -> L8 conversion uses scalar code. It would be a lot faster if user decodes image into L8 pixel type.
There was a problem hiding this comment.
Yeah theres definitely optimisation opportunity there.
JimBobSquarePants
approved these changes
Mar 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
Based on discussion from #2039. I've split jpeg encoding benchmark into ImageSharp-only benchmark with all supported color types and 'cross-codec' which compares ImageSharp with other codec (only SkiaSharp currently as
System.Drawingis unreliable on Linux).I've also deleted multi-image benchmark as new benchmarks can be used via replacing filename from const string to string with
Paramsattribute.Ideally, we would want to create a encode-decode benchmark as it's would be a lot easier to trace and compare to something like MagicScaler as its decoding is tighly coupled with encoding.
Decode-Resize-Encode benchmark would also be helpful and I'd implement it during jpeg dct scaling PR somewhere in the future - no point implementing it now.