Extend row operation interfaces with buffer length method #2241
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
Some implementation of
IRowOperation{T}
andIRowIntervalOperation{T}
interfaces use buffer length other than the width of the bounds. Examples are most convolution processors.This PR makes the required buffer length an explicit method in these interfaces. This introduces some boiler plate code when the
IRowOperation{T}
is using the default, but I think the readability of the code improves even there. When re-usingIRowOperation{T}
implementations in other processors, the internal knowledge of the buffer length is no longer required. Last but not least, my personal trigger to start this PR: It eliminates contributors going back and forth between the RowOperation and the Processor when the buffer length is changed in the code.Also, implemented buffered pixel conversions in Normalization processors using these extended interfaces.
I feel the existing test cover the changes in this PR already. Let me know if you feel otherwise.