-
-
Notifications
You must be signed in to change notification settings - Fork 851
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add BuildJet ARM64 runners. #2341
Conversation
@brianpopow got some failing stuff here. Seems System.Drawing related. Will need to make some additional changes. Anything obvious you can think of from your PR? |
mhm I first thought all the runner were green. It looks like libgdi+ dependency is missing. Should be easy to add, I will take a look. |
@brianpopow I had to do a bit more work to get everything green. Everything checks out now though and I've manually verified all output. Those previous green runs you approved existed because I chose the wrong runners. AMD instead of ARM! I should code less late at night! 🤪 |
@JimBobSquarePants I tried to run the tests on my ARM device and had |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is ready now for merging, glad we can now finally test on ARM.
Prerequisites
Description
I've signed up for an ARM64 runner via BuildJet.
https://buildjet.com/for-github-actions/docs/runners#which-runner-should-i-use
Fingers crossed this works out-of-the-box as documentation is light.