Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BuildJet ARM64 runners. #2341

Merged
merged 20 commits into from
Feb 5, 2023
Merged

Add BuildJet ARM64 runners. #2341

merged 20 commits into from
Feb 5, 2023

Conversation

JimBobSquarePants
Copy link
Member

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

I've signed up for an ARM64 runner via BuildJet.

https://buildjet.com/for-github-actions/docs/runners#which-runner-should-i-use

Fingers crossed this works out-of-the-box as documentation is light.

@JimBobSquarePants
Copy link
Member Author

@brianpopow got some failing stuff here. Seems System.Drawing related. Will need to make some additional changes. Anything obvious you can think of from your PR?

@brianpopow
Copy link
Collaborator

@brianpopow got some failing stuff here. Seems System.Drawing related. Will need to make some additional changes. Anything obvious you can think of from your PR?

mhm I first thought all the runner were green. It looks like libgdi+ dependency is missing. Should be easy to add, I will take a look.

@JimBobSquarePants
Copy link
Member Author

JimBobSquarePants commented Feb 4, 2023

@brianpopow I had to do a bit more work to get everything green. Everything checks out now though and I've manually verified all output.

Those previous green runs you approved existed because I chose the wrong runners. AMD instead of ARM! I should code less late at night! 🤪

@brianpopow
Copy link
Collaborator

@JimBobSquarePants I tried to run the tests on my ARM device and had BmpDecoder_CanDecode_Os2BitmapArray failing. Turns out the testfiles did have upper case file-endings. This was causing them not being treated as binary files from git-lfs. I am not sure why this only fails on my device, though. Fixed now with 3fd4fdc

Copy link
Collaborator

@brianpopow brianpopow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is ready now for merging, glad we can now finally test on ARM.

@JimBobSquarePants JimBobSquarePants merged commit bd9fc66 into main Feb 5, 2023
@JimBobSquarePants JimBobSquarePants deleted the js/buildjet-arm64 branch February 5, 2023 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants