Restrict trigger for ARM to PRs containing labels only #2343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
First run with condition excludes ARM matrix entries. Now adding labels to ensure they are captured. |
|
@brianpopow It works!! |
JimBobSquarePants
changed the title
brianpopow
reviewed
Feb 5, 2023
| @@ -58,6 +61,10 @@ jobs: | |||
| sdk: 6.0.x | |||
| runtime: -x64 | |||
| codecov: false | |||
| exclude: | |||
| - isARM: false | |||
There was a problem hiding this comment.
@JimBobSquarePants: I am not sure that I understand the intention of the exclude here, does that mean only the arm runners should be executed and all others should not run?
There was a problem hiding this comment.
Exclude the ARM runners unless the label exists.
I thought best to run the other runners at all times which helps us avoid any errors we potentially introduce with conditionals.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
Trying to keep the ARM build runner checks to a minimum to reduce costs.
Following a combination of the following instructions
https://stackoverflow.com/questions/62325286/run-github-actions-when-pull-requests-have-a-specific-label#comment122159108_62331521
https://github.com/orgs/community/discussions/26253#discussioncomment-3250989