Allow setting configuration property #2357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -15,15 +15,21 @@ public sealed class DecoderOptions | |||
|
|
|||
| private uint maxFrames = int.MaxValue; | |||
|
|
|||
| // Used by the FileProvider in the unit tests to set the configuration on the fly. | |||
There was a problem hiding this comment.
Yeah. I know. This is nasty but so is the file provider.
JimBobSquarePants
requested review from
antonfirsov,
brianpopow,
dlemstra and
tocsoft
antonfirsov
reviewed
Feb 16, 2023
Comment on lines
19
to
21
| #pragma warning disable SA1401 // Fields should be private | ||
| internal Configuration BackingConfiguration = Configuration.Default; | ||
| #pragma warning restore SA1401 // Fields should be private |
There was a problem hiding this comment.
Why not a member SetConfiguration() method and a private field?
There was a problem hiding this comment.
Yeah... I was trying to avoid adding to the method itself and overcomplicated things. I moved it but still had to suppress a warning as the IDE thinks incorrectly that it can be an auto-implemented property.
5 tasks
antonfirsov
approved these changes
Feb 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
The property was internal when it shouldn't be.