Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable preEnumerateTheories for running tests #2360

Merged
merged 2 commits into from
Feb 19, 2023

Conversation

brianpopow
Copy link
Collaborator

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

Added "preEnumerateTheories": false to the xunit config, to avoid many useless warnings during tests.

@JimBobSquarePants
Copy link
Member

I've never heard of this setting before now. Is it masking errors or just stopping an issue within Xunit?

@brianpopow
Copy link
Collaborator Author

I've never heard of this setting before now. Is it masking errors or just stopping an issue within Xunit?

It just gets rid of the warnings like:

[xUnit.net 00:00:04.57] SixLabors.ImageSharp.Tests: Non-serializable data ('System.Object[]') found for 'SixLabors.ImageSharp.Tests.Formats.Tiff.PhotometricInterpretation.WhiteIsZeroTiffColorTests.Decode_WritesPixelData_4Bit'; falling back to single test case.

We get those message for every test which uses MemberData and I do find this quite annoying.

@JimBobSquarePants
Copy link
Member

I HATE those warnings!

@brianpopow brianpopow merged commit 5ebc460 into main Feb 19, 2023
@brianpopow brianpopow deleted the bp/disablePreEnumerateTheories branch February 19, 2023 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants