Fix RgbScalar #2416
Merged
Fix RgbScalar #2416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We need a test to cover this issue. I will try to help here. There are more color converter path's which are not covered by tests: ColorConverters. We need not add more unit tests there (@stefannikolei: not necessary you, btw). |
…Runner to disable specific hw features
…tRunner to disable specific hw features
…stRunner to disable specific hw features
…tRunner to disable specific hw features
…reTestRunner to disable specific hw features
|
I have added tests now to cover all path for JpegColorConverterBase I think its ready for review now. |
4 tasks
antonfirsov
approved these changes
Mar 27, 2023
Ycbcr is implemented in #2417 You can check the performance in the prs. All have benchmarks attached |
Ah for some reason I thought that was already merged 😄 With those numbers it makes sense thanks! |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
I ran the tests with SSE Disabled. And I found this bug...
Before fixing it I had 151 failing tests after it only 53 tests are failing. On a quick check all other failures are 'Image difference is over threshold!'