Addition of Breadley AdaptiveThreshold #725

SimantoR · 2018-10-05T03:20:02Z

Adaptive Threshold

Description

Added Bradley Adaptive Threshold, tweaked from the original published paper by Derek Bradley of Carleton University and Gerhard Roth of National Research Council of Canada. It has been tested on the sample document used in the paper.

TODO

Add optimization techniques
Add unit test
Test on different variety of document images

JimBobSquarePants · 2018-10-05T07:53:22Z

src/ImageSharp/Processing/Processors/Binarization/AdaptiveThresholdProcessor.cs

+        /// </summary>
+        public TPixel Lower { get; set; }
+
+        public unsafe void Apply(Image<TPixel> source, Rectangle sourceRectangle)


Why unsafe?

Oh! forgot to remove that, was doing some experimenting but since there are 2DArray pool I didn't implement it. Will remove it asap.

src/ImageSharp/Processing/Processors/Binarization/AdaptiveThresholdProcessor.cs

# Inherited from ImageProcessor # Minor changes to variables # Minor Tweaks

codecov · 2018-10-05T15:05:35Z

Codecov Report

Merging #725 into master will increase coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #725      +/-   ##
==========================================
+ Coverage   82.32%   82.37%   +0.05%     
==========================================
  Files         681      684       +3     
  Lines       29438    29522      +84     
  Branches     3325     3330       +5     
==========================================
+ Hits        24234    24318      +84     
  Misses       4515     4515              
  Partials      689      689

Flag	Coverage Δ
#unittests	`82.37% <100.00%> (+0.05%)`	⬆️

Impacted Files	Coverage Δ
...ageSharp/Processing/AdaptiveThresholdExtensions.cs	`100.00% <100.00%> (ø)`
...cessors/Binarization/AdaptiveThresholdProcessor.cs	`100.00% <100.00%> (ø)`
...Binarization/AdaptiveThresholdProcessor{TPixel}.cs	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fedf5b7...ee016f6. Read the comment docs.

SimantoR · 2018-10-13T06:00:10Z

One question does arise from the attempt to implement Parallelism into this algorithm:
Since there are 2 identical loops that needs to be performed in series, should they be individually implement into their own Parallel loops? It seems like the logical thing to do

JimBobSquarePants · 2018-10-21T19:46:42Z

Haven't forgotten about this. Will get it merged eventually!

JimBobSquarePants

Couple of questions on stuff I don't understand.

src/ImageSharp/Processing/Processors/Binarization/AdaptiveThresholdProcessor.cs

JimBobSquarePants · 2019-01-24T02:31:00Z

@SimantoR This is next on my todo list for review and will helping you finish it off.

zmmille2 · 2019-05-31T18:49:03Z

Any update on this? Would really like to use it in a project I've got going on.

SimantoR · 2019-06-01T10:26:05Z

Any update on this? Would really like to use it in a project I've got going on.

@zmmille2
Hi there. It's Eid time and I've been looking forward to getting this packaged and ready for ImageSharp. Feel free to add anything to the fork for this PR here. It currently is greatly outdated and no unit test has been implemented for this. I'm going to update the repo to be concurrent with the current version but I do need help with the unit tests.

brianpopow · 2020-04-02T10:30:28Z

If the only thing left here are unit tests, i can do that. Will take test images from the original paper. For example:

works great.

JimBobSquarePants · 2020-04-02T10:40:53Z

Yeah @brianpopow that would be great!

src/ImageSharp/Processing/Processors/Binarization/AdaptiveThresholdProcessor{TPixel}.cs

JimBobSquarePants · 2020-04-02T19:53:15Z

src/ImageSharp/Processing/Processors/Binarization/AdaptiveThresholdProcessor{TPixel}.cs

+                    TPixel pixel = pixelRow[x];
+                    pixel.ToRgba32(ref rgb);
+
+                    var x1 = (ushort)Math.Max(x - this.startX - this.clusterSize + 1, 0);


This cast limits our range. If x or y are greater than ushort.MaxValue we end up with the wrong offset.

somehow i managed to miss that

src/ImageSharp/Processing/Processors/Binarization/AdaptiveThresholdProcessor{TPixel}.cs

JimBobSquarePants

Looks great! Thanks for finishing this off 👍

SimantoR · 2020-04-06T13:41:22Z

That's great to see. I just saw the activity on this PR. I'm so glad this got finished!

Addition of Breadley AdaptiveThreshold

e1d39de

JimBobSquarePants reviewed Oct 5, 2018

View reviewed changes

src/ImageSharp/Processing/Processors/Binarization/AdaptiveThresholdProcessor.cs Outdated Show resolved Hide resolved

# Added Rect.Intersect

152b8e6

# Inherited from ImageProcessor # Minor changes to variables # Minor Tweaks

SimantoR added 3 commits October 6, 2018 12:16

Merge branch 'master' into master

7951548

Merge branch 'master' into master

170a65d

Merge branch 'master' into master

5d61a3f

SimantoR closed this Oct 13, 2018

SimantoR reopened this Oct 13, 2018

Added parallelism to loops

95a7b0d

JimBobSquarePants reviewed Oct 23, 2018

View reviewed changes

SimantoR and others added 14 commits October 23, 2018 13:54

Merge branch 'master' into master

1e7dc83

Temporary fix to accomodate SixLabors#744

2b6d93a

Few general changes without effecting the algorithm implementation

bb5cc29

Merge branch 'master' into master

ba8929c

Merge branch 'master' of https://github.com/SimantoR/ImageSharp

a501113

Fixed few breaking changes

d8f3b39

Missed an end of line by accident :p

8978bc3

Used TempBuffer and fixed few logical errors

6805f6d

Added contructor to control threshold limit

b054102

Fixed several bugs produced during parallelism implementations

319fc95

Algorithm behaves abnormally when applied with ParallelHelpers

a239e60

Fully working implementation

1f52c9d

Changed naming convention for threshold limit param

31e5d8d

Fixed a minor bug

8610f5c

JimBobSquarePants added the enhancement label Jan 24, 2019

JimBobSquarePants added this to the 1.0.0 milestone Jan 24, 2019

update to most recent version

be3718d

brianpopow added 2 commits April 2, 2020 12:05

Re-add external test images

a5a0ecd

Merge remote-tracking branch 'upstream/master'

019d973

brianpopow self-assigned this Apr 2, 2020

Adjustments to changes from the upstream

39d5a93

JimBobSquarePants reviewed Apr 2, 2020

View reviewed changes

src/ImageSharp/Processing/Processors/Binarization/AdaptiveThresholdProcessor{TPixel}.cs Outdated Show resolved Hide resolved

src/ImageSharp/Processing/Processors/Binarization/AdaptiveThresholdProcessor{TPixel}.cs Outdated Show resolved Hide resolved

brianpopow added 4 commits April 2, 2020 15:18

Add tests for the AdaptiveThreshold processor

6963945

Remove not needed tmp buffer

75ac0ee

Changed startX and endX from ushort to int, Add test with rectangle

a468883

Using pixel row span to access the pixels

1c92670

JimBobSquarePants reviewed Apr 2, 2020

View reviewed changes

src/ImageSharp/Processing/Processors/Binarization/AdaptiveThresholdProcessor{TPixel}.cs Outdated Show resolved Hide resolved

brianpopow added 2 commits April 2, 2020 23:15

Review changes

50aa77e

Minor formatting change

ee016f6

JimBobSquarePants approved these changes Apr 3, 2020

View reviewed changes

JimBobSquarePants merged commit 557b1c5 into SixLabors:master Apr 3, 2020

JimBobSquarePants modified the milestones: 1.0.0, 1.0.0-rc1 Apr 24, 2020

JimBobSquarePants mentioned this pull request Sep 1, 2022

Fix AdaptiveThresholdProcessor throws IndexOutOfRangeException #2221

Merged

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Addition of Breadley AdaptiveThreshold #725

Addition of Breadley AdaptiveThreshold #725

SimantoR commented Oct 5, 2018 •

edited by JimBobSquarePants

Loading

JimBobSquarePants Oct 5, 2018

SimantoR Oct 5, 2018

codecov bot commented Oct 5, 2018 •

edited

Loading

SimantoR commented Oct 13, 2018

JimBobSquarePants commented Oct 21, 2018

JimBobSquarePants left a comment

JimBobSquarePants commented Jan 24, 2019

zmmille2 commented May 31, 2019

SimantoR commented Jun 1, 2019 •

edited

Loading

brianpopow commented Apr 2, 2020

JimBobSquarePants commented Apr 2, 2020

JimBobSquarePants Apr 2, 2020

brianpopow Apr 2, 2020

JimBobSquarePants left a comment

SimantoR commented Apr 6, 2020

Addition of Breadley AdaptiveThreshold #725

Addition of Breadley AdaptiveThreshold #725

Conversation

SimantoR commented Oct 5, 2018 • edited by JimBobSquarePants Loading

Adaptive Threshold

Description

TODO

JimBobSquarePants Oct 5, 2018

Choose a reason for hiding this comment

SimantoR Oct 5, 2018

Choose a reason for hiding this comment

codecov bot commented Oct 5, 2018 • edited Loading

Codecov Report

SimantoR commented Oct 13, 2018

JimBobSquarePants commented Oct 21, 2018

JimBobSquarePants left a comment

Choose a reason for hiding this comment

JimBobSquarePants commented Jan 24, 2019

zmmille2 commented May 31, 2019

SimantoR commented Jun 1, 2019 • edited Loading

brianpopow commented Apr 2, 2020

JimBobSquarePants commented Apr 2, 2020

JimBobSquarePants Apr 2, 2020

Choose a reason for hiding this comment

brianpopow Apr 2, 2020

Choose a reason for hiding this comment

JimBobSquarePants left a comment

Choose a reason for hiding this comment

SimantoR commented Apr 6, 2020

SimantoR commented Oct 5, 2018 •

edited by JimBobSquarePants

Loading

codecov bot commented Oct 5, 2018 •

edited

Loading

SimantoR commented Jun 1, 2019 •

edited

Loading