-
-
Notifications
You must be signed in to change notification settings - Fork 851
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce a non-generic Image base class #904
Conversation
add suppression of SA1413 to AssemblyInfo.cs
Codecov Report
@@ Coverage Diff @@
## master #904 +/- ##
==========================================
- Coverage 89.55% 89.23% -0.32%
==========================================
Files 1031 1060 +29
Lines 46115 46028 -87
Branches 3261 3268 +7
==========================================
- Hits 41297 41074 -223
- Misses 4108 4205 +97
- Partials 710 749 +39
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #904 +/- ##
=========================================
+ Coverage 89.55% 89.6% +0.04%
=========================================
Files 1031 1060 +29
Lines 46115 46542 +427
Branches 3261 3268 +7
=========================================
+ Hits 41297 41702 +405
- Misses 4108 4129 +21
- Partials 710 711 +1
Continue to review full report at Codecov.
|
I'm very happy for the most part with this thus far. I'd like to know more about your concerns with the Histogram naming and would like to help there. |
On the other hand, |
I think we’ve still got a long way to go before we hit the dizzy heights of https://github.com/dotnet/roslyn/blob/master/src/Compilers/CSharp/Portable/BoundTree/BoundTreeRewriter.cs#L100 So I’m ok with the longer form |
Ok, went with the longer names. All processors without color parameters should be |
I'm merging this to go on with the rest of #907. If I made a mistake, I will be able to fix it in the follow up PR-s. |
…baseclass Introduce a non-generic Image base class
Prerequisites
Description
Image<TPixel>
to work onImage
instead:Image.Load
variants, discovered and added a few missing overloadsHope I haven't missed any of the important processors and / or extensions!
To enable extensions using color values as parameters on
Image
, we need to introduce a pixel-agnostic color type. I have a proposal for this, planning to PR it within the next week.