Add a way to do command line completion in sanssh. #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I ended up adding a more comprehensive unit test. |
See steps in the readme for how to enable this. It relies on invoking sanssh for suggestions. Downstream clients can use `client.AddCommandLineCompletion` to take advantage of this. This completion automatically registers subcommand packages and their flags. To register subcommands of subcommands, the parent subcommand needs to implement HasSubpackage. I've updated all the services to implement that interface. There's also a PredictArgs interface that can be used to predict command line arguments of subcommands. I've experimented with adding this to some of the fdb subcommands. Finally, I've tweaked the default fail-early behavior so that there's help text from running a command like `sanssh` or `sanssh exec` insted of a cryptic "Must set a target or a proxy" error.
The tests helped catch that I wasn't always handling the final args after a subcommand correctly. The flag handling now autocompletes --foo= in addition to --foo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See steps in the readme for how to enable this. It relies on invoking sanssh for suggestions. Downstream clients can use
client.AddCommandLineCompletionto take advantage of this.This completion automatically registers subcommand packages and their flags. To register subcommands of subcommands, the parent subcommand needs to implement HasSubpackage. I've updated all the services to implement that interface.
There's also a PredictArgs interface that can be used to predict command line arguments of subcommands. I've experimented with adding this to some of the fdb subcommands.
Finally, I've tweaked the default fail-early behavior so that there's help text from running a command like
sansshorsanssh execinsted of a cryptic "Must set a target or a proxy" error.