Add a progress bar for file copying. #457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This uses https://pkg.go.dev/github.com/schollz/progressbar/v3 in the most basic way. Copying larger files can get very confusing without feedback because it can be unclear on how much progress has been made, whether progress is ongoing, and how long until the command will be complete. A progress bar helps a lot for understandability. File copying is currently implemented by synchronously sending bytes to be copied to all targets, so a single progress bar is sufficient for tracking progress across all targets. Example of how this looks mid-run: ``` ❯ go run ./cmd/sanssh -targets localhost file cp -username stvn -group stvn -mode 0755 ./cmd/sansshell-server/sansshell-server /tmp/s 52% |██████████████████████████████████████████████████████████████████████████████████████ | (38/72 MB, 1.6 MB/s) [26s:22s] ```
sfc-gh-elinardi
approved these changes
Jul 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses https://pkg.go.dev/github.com/schollz/progressbar/v3 in the most basic way. Copying larger files can get very confusing without feedback because it can be unclear on how much progress has been made, whether progress is ongoing, and how long until the command will be complete. A progress bar helps a lot for understandability.
File copying is currently implemented by synchronously sending bytes to be copied to all targets, so a single progress bar is sufficient for tracking progress across all targets.
Example of how this looks mid-run:
I've put in a "is directory" check too because the previous code confusingly hung indefinitely when asked to copy a directory.