Expose more of HTTPOverRPC's feature set to sanssh httpoverrpc proxy
#469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We added a few RPC-level features like contacting a host other than localhost and supporting https, but only exposed them in `httpoverrpc get`. Let's expose them in the proxy too so that we have feature parity.
sfc-gh-elinardi
approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We added a few RPC-level features like contacting a host other than localhost and supporting https, but only exposed them in
httpoverrpc get. Let's expose them in the proxy too so that we have feature parity.This makes it possible to run commands that proxy through the host to another source that it can reach, or to proxy to a https port on localhost.