Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract license check from integration tests #473

Merged
merged 2 commits into from
Aug 27, 2024
Merged

Extract license check from integration tests #473

merged 2 commits into from
Aug 27, 2024

Conversation

sfc-gh-ikryvanos
Copy link
Collaborator

I made several changes to improve developer experience and speed up development:

  • add separate license check on CI, to see clear PR status
  • add license check on pre-commit, to get early feedback about missing license to speed up development cycle significantly
  • use same license check script on CI and pre-commit, to have single source of truth for license check logic
  • remove license check from integration test to speed up it and make it status more transparent

@sfc-gh-ikryvanos sfc-gh-ikryvanos mentioned this pull request Aug 16, 2024
Merged
1 task
sfc-gh-srhodes
sfc-gh-srhodes approved these changes Aug 16, 2024
View reviewed changes
.pre-commit-config.yaml Outdated Show resolved Hide resolved
@sfc-gh-ikryvanos
Extract license check from integration tests
995dceb 
Add separate CI and pre-commit to check license
@sfc-gh-ikryvanos sfc-gh-ikryvanos force-pushed the ikryvanos/2024-08_extract-license-check branch from fc46e72 to 995dceb Compare August 27, 2024 16:53
@sfc-gh-ikryvanos sfc-gh-ikryvanos enabled auto-merge (squash) August 27, 2024 16:53
@sfc-gh-ikryvanos sfc-gh-ikryvanos merged commit e7ef4fa into main Aug 27, 2024
7 checks passed
@sfc-gh-ikryvanos sfc-gh-ikryvanos deleted the ikryvanos/2024-08_extract-license-check branch August 27, 2024 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-srhodes sfc-gh-srhodes sfc-gh-srhodes approved these changes

@sfc-gh-elinardi sfc-gh-elinardi Awaiting requested review from sfc-gh-elinardi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sfc-gh-ikryvanos @sfc-gh-srhodes